CURA-11364 Add Sentry Support #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne into CURA-11364_add_sentry
By default it stores them in the cwd, which won't work for actual instals. It now places them in the root Cura folder CURA-11364
…ne into CURA-11364_add_sentry
The update adds an option to enable or disable Sentry integration in the code. Sentry is configured to capture and report crashes only if the appropriate option is enabled and a valid DSN (data source name) is provided. The suitable changes have been made in the Conan, CMake configurations and source code files. To compile locally with Sentry support run the conan install command with: ``` -c user.curaengine:sentry_url=<url> -o curaengine:enable_sentry=True ``` For the runners the conf `user.curaengine:sentry_url` has been added to the relevant runner profiles. Once the new workflows have been merged that url will move out of the profiles and passed along as a repository variable in the GH runner. Contributes to CURA-11364
The revision consists of refactoring of the sentry options in the main.cpp file, including setting the database path and release version. The filesystem library and fmt library have been used to improve the code readability and simplicity. Also, some changes have been made in the CMakeLists.txt file, specifically for enabling sentry and its related configurations. Contributes to CURA-11364
The sentry config path creation is improved by leveraging the fmt library to format the respective path strings. This change streamlines the code and boosts its overall comprehensibility. Also, the sentry options set database path now makes use of the native function for string conversion. Contributes to CURA-11364
Made sure that user identifiable paths aren't logged with a custom formatter. See example output on Linux ``` [2023-11-21 14:57:13.764] [info] Sentry config path: /home/*******/.local/share/cura/.sentry-native ``` Untested on Windows Contributes to CURA-11364
Contributes to CURA-11364
The issue was windows defaults to wide-strings. Sadly sentry doesn't seem to take wide-string paths, so that users with non-ASCII names might be left out again :-/ part of CURA-11364
rburema
reviewed
Nov 22, 2023
The file 'subrange.hpp' of the ranges library wouldn't compile properly on Windows, work around this strange limitation. part of CURA-11364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for sentry in the engine, which will give us much better insights regarding slicing crashes.
CURA-11364
Goes with: Ultimaker/Cura#17394
Type of change