Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect path config usage #1962

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix incorrect path config usage #1962

merged 1 commit into from
Oct 4, 2023

Conversation

casperlamboo
Copy link
Contributor

@casperlamboo casperlamboo commented Oct 3, 2023 •
edited
Loading

The path configs was hard coded to the skin config. By doing this the wrong config was used in (at least) two instances.

  • bridging extra skin walls
  • top surface extra skin walls

Before this fix
Screenshot 2023-10-03 at 19 54 36

With this fix
Screenshot 2023-10-03 at 19 45 36

CURA-11119
CURA-11121

@casperlamboo casperlamboo changed the title CURA-11119-CURA-11121-correct-path-config Fix incorrect path config usage Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Unit Test Results

26 tests  ±0   26 ✔️ ±0   9s ⏱️ -4s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 873800b. ± Comparison against base commit 40cd391.

@casperlamboo casperlamboo changed the base branch from main to 5.5 October 3, 2023 18:07
@rburema rburema merged commit a8cc7b7 into 5.5 Oct 4, 2023
21 checks passed
@rburema rburema deleted the CURA-11119-CURA-11121-correct-path-config branch October 4, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rburema rburema rburema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casperlamboo @rburema