Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support brim printed only at layer 0 #1956

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Support brim printed only at layer 0 #1956

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43955a1
Support brim printed only at layer 0
saumyaj3 Sep 25, 2023
26c7522
Applied clang-format.
saumyaj3 Sep 25, 2023
e2203b0
Comment fix
saumyaj3 Sep 25, 2023
0acf5cf
Merge branch '5.5' into CURA-10968_skirt_height_printed_at_support
saumyaj3 Sep 27, 2023
f832ec8
Comment fix
saumyaj3 Sep 29, 2023
f7a8e3d
Merge remote-tracking branch 'origin/CURA-10968_skirt_height_printed_…
saumyaj3 Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions src/FffGcodeWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1232,24 +1232,28 @@ void FffGcodeWriter::processSkirtBrim(const SliceDataStorage& storage, LayerPlan


// Add the support brim after the skirt_brim to gcode_layer
// Support brim is only added in layer 0
// For support brim we don't care about the order, because support doesn't need to be accurate.
const Settings& mesh_group_settings = Application::getInstance().current_slice->scene.current_mesh_group->settings;
if (extruder_nr == mesh_group_settings.get<ExtruderTrain&>("support_extruder_nr_layer_0").extruder_nr)
if (layer_nr == 0)
{
total_line_count += storage.support_brim.size();
Polygons support_brim_lines = storage.support_brim;
support_brim_lines.toPolylines();
gcode_layer.addLinesByOptimizer(
support_brim_lines,
gcode_layer.configs_storage.skirt_brim_config_per_extruder[extruder_nr],
SpaceFillType::PolyLines,
enable_travel_optimization,
wipe_dist,
flow_ratio,
start_close_to,
fan_speed,
reverse_print_direction,
order_requirements = {});
const Settings& mesh_group_settings = Application::getInstance().current_slice->scene.current_mesh_group->settings;
if (extruder_nr == mesh_group_settings.get<ExtruderTrain&>("support_extruder_nr_layer_0").extruder_nr)
saumyaj3 marked this conversation as resolved.
Show resolved Hide resolved
{
total_line_count += storage.support_brim.size();
Polygons support_brim_lines = storage.support_brim;
support_brim_lines.toPolylines();
gcode_layer.addLinesByOptimizer(
support_brim_lines,
gcode_layer.configs_storage.skirt_brim_config_per_extruder[extruder_nr],
SpaceFillType::PolyLines,
enable_travel_optimization,
wipe_dist,
flow_ratio,
start_close_to,
fan_speed,
reverse_print_direction,
order_requirements = {});
}
}
}

Expand Down
Loading