Remove interaction between briding and seam overhang

CURA-12164
Ultimaker · Oct 18, 2024 · b0cf410 · b0cf410
1 parent 03de538
commit b0cf410
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/include/LayerPlan.h b/include/LayerPlan.h
@@ -299,9 +299,9 @@ class LayerPlan : public NoCopy
     void setSeamOverhangMask(const Shape& polys);
 
     /*!
-     * Get the areas that are considered having air below, which is a union between bridge and overhang masks
+     * Get the seam overhang mask, which contains the areas where we don't want to place the seam because they are overhanding
      */
-    Shape getAirBelowMask() const;
+    const Shape& getSeamOverhangMask() const;
 
     /*!
      * Set roofing_mask.

diff --git a/src/FffGcodeWriter.cpp b/src/FffGcodeWriter.cpp
@@ -3149,7 +3149,7 @@ bool FffGcodeWriter::processInsets(
             disallowed_areas_for_seams,
             scarf_seam,
             smooth_speed,
-            gcode_layer.getAirBelowMask());
+            gcode_layer.getSeamOverhangMask());
         added_something |= wall_orderer.addToLayer();
     }
     return added_something;

diff --git a/src/LayerPlan.cpp b/src/LayerPlan.cpp
@@ -2381,7 +2381,7 @@ void LayerPlan::writeGCode(GCodeExport& gcode)
 
             for (const auto& reversed_chunk : paths | ranges::views::enumerate | ranges::views::reverse
                                                   | ranges::views::chunk_by(
-                                                      [](const auto&path_a, const auto&path_b)
+                                                      [](const auto& path_a, const auto& path_b)
                                                       {
                                                           return (! std::get<1>(path_a).isTravelPath()) || std::get<1>(path_b).isTravelPath();
                                                       }))
@@ -3044,9 +3044,9 @@ void LayerPlan::setSeamOverhangMask(const Shape& polys)
     seam_overhang_mask_ = polys;
 }
 
-Shape LayerPlan::getAirBelowMask() const
+const Shape& LayerPlan::getSeamOverhangMask() const
 {
-    return bridge_wall_mask_.unionPolygons(seam_overhang_mask_);
+    return seam_overhang_mask_;
 }
 
 void LayerPlan::setRoofingMask(const Shape& polys)