Skip to content

Commit

Permalink
Set relative path to output file
Browse files Browse the repository at this point in the history
  • Loading branch information
@wawanbreton
wawanbreton committed Dec 20, 2024
1 parent a8c7105 commit b0a18e9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/benchmark.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ jobs:
uses: ultimaker/cura-workflows/.github/workflows/benchmark.yml@main
with:
conan_extra_args: "-o \"curaengine/*:enable_benchmarks=True\""
benchmark_cmd: "./build/Release/benchmark/benchmarks --benchmark_format=json --benchmark_out=benchmark_result.json"
benchmark_cmd: "benchmark/benchmarks --benchmark_format=json --benchmark_out=benchmark_result.json"
name: "C++ Benchmark"
output_file_path: "build/Release/benchmark_result.json"
output_file_path: "benchmark_result.json"
data_dir: "dev/bench"
tool: "googlecpp"
alert_threshold: "150%"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stress_benchmark.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
conan_extra_args: "-o curaengine:enable_benchmarks=True"
benchmark_cmd: "stress_benchmark/stress_benchmark -o benchmark_result.json"
name: "Stress Benchmark"
output_file_path: "build/Release/benchmark_result.json"
output_file_path: "benchmark_result.json"
data_dir: "dev/stress_bench"
tool: "customSmallerIsBetter"
secrets: inherit

1 comment on commit b0a18e9

@rburema
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: b0a18e9 Previous: 1812a2e Ratio
SimplifyTestFixture/simplify_slot_noplugin 3.7144289219605002 ns/iter 1.2416562286374633 ns/iter 2.99

This comment was automatically generated by workflow using github-action-benchmark.

CC: @nallath @jellespijker @wawanbreton @casperlamboo @saumyaj3 @HellAholic

Please sign in to comment.