Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweaks common terms for Japanese translation #19831

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

h1data
Copy link
Contributor

@h1data h1data commented Oct 30, 2024

Description

Tweaks common terms for Japanese translation.

  • preference: プレファレンス -> 環境設定
  • overlap (i.e. infill) : 重複 -> 重なり

Type of change

  • Translations

How Has This Been Tested?

  • compiled to mo files and tested in 5.9.1.

Test Configuration:

  • Operating System: Windows 11

Checklist:

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Oct 30, 2024
@h1data
Copy link
Contributor Author

h1data commented Oct 30, 2024

@wawanbreton
I have discussed this with @bgpat and decided to change a few common terms for 5.9.
I'm sorry to bother you, but could you check and merge this and Ultimaker/Uranium#976 into 5.9?

@wawanbreton
Copy link
Contributor

No problem, I'm very glad that you could find someone to double-check, and do the changes this fast 🙂

Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise good to go !

resources/i18n/ja_JP/fdmprinter.def.json.po Show resolved Hide resolved
@wawanbreton wawanbreton merged commit 7c0b8d2 into Ultimaker:5.9 Oct 30, 2024
10 of 12 checks passed
@wawanbreton
Copy link
Contributor

@h1data and @bgpat Thanks again for your amazing work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants