Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/reorganize settings for raft walls #17946

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Add/reorganize settings for raft walls #17946

merged 2 commits into from
Jan 8, 2024

Conversation

wawanbreton
Copy link
Contributor

@wawanbreton wawanbreton commented Jan 8, 2024 •
edited
Loading

  • Add settings raft_wall_count, raft_interface_wall_count and raft_surface_wall_count
  • Move setting raft_base_wall_count to child of raft_wall_count

Default values for interface and surface layers are 0 to keep retro-compatibility. Value for base layer is linked to the parent.

Contributes to CURA-11228
See associated PR Ultimaker/CuraEngine#2007

@wawanbreton wawanbreton mentioned this pull request Jan 8, 2024
Merged
@casperlamboo casperlamboo merged commit 650bed1 into main Jan 8, 2024
7 of 9 checks passed
@casperlamboo casperlamboo deleted the CURA-11228_raft_walls branch January 8, 2024 16:10
@MariMakes MariMakes mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperlamboo casperlamboo casperlamboo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wawanbreton @casperlamboo