Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extruder start/end gcode duration settings #17301

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Add extruder start/end gcode duration settings #17301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4573ba
Add extruder start/end gcode duration settings
casperlamboo Nov 13, 2023
d56b77d
Applied printer-linter format
casperlamboo Nov 13, 2023
2c1f0fc
Apply suggestions from code review
casperlamboo Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions plugins/MachineSettingsAction/MachineSettingsExtruderTab.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,34 @@ Item
decimals: 0
forceUpdateOnChangeFunction: forceUpdateFunction
}

Cura.NumericTextFieldWithUnit
{
id: extruderStartCodeDurationFieldId
containerStackId: base.extruderStackId
settingKey: "machine_extruder_start_code_duration"
settingStoreIndex: propertyStoreIndex
labelText: catalog.i18nc("@label", "Extruder Start G-code duration")
labelFont: base.labelFont
labelWidth: base.labelWidth
controlWidth: base.controlWidth
unitText: catalog.i18nc("@label", "s")
forceUpdateOnChangeFunction: forceUpdateFunction
}

Cura.NumericTextFieldWithUnit
{
id: extruderEndCodeDurationFieldId
containerStackId: base.extruderStackId
settingKey: "machine_extruder_end_code_duration"
settingStoreIndex: propertyStoreIndex
labelText: catalog.i18nc("@label", "Extruder End G-code duration")
labelFont: base.labelFont
labelWidth: base.labelWidth
controlWidth: base.controlWidth
unitText: catalog.i18nc("@label", "s")
forceUpdateOnChangeFunction: forceUpdateFunction
}
}
}

Expand Down
24 changes: 24 additions & 0 deletions resources/definitions/fdmextruder.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,18 @@
"settable_per_meshgroup": false,
"type": "str"
},
"machine_extruder_end_code_duration":
{
"default_value": 0,
"description": "The time it takes to execute the end g-code, when switching away from this extruder.",
"label": "Extruder End G-Code Duration",
"minimum_value": "0",
"settable_globally": false,
"settable_per_extruder": true,
"settable_per_mesh": false,
"settable_per_meshgroup": false,
"type": "float"
},
"machine_extruder_end_pos_abs":
{
"default_value": false,
Expand Down Expand Up @@ -108,6 +120,18 @@
"settable_per_meshgroup": false,
"type": "str"
},
"machine_extruder_start_code_duration":
{
"default_value": 0,
"description": "The time it'll take to execute the start g-code, when switching to this extruder.",
"label": "Extruder Start G-Code Duration",
"minimum_value": "0",
"settable_globally": false,
"settable_per_extruder": true,
"settable_per_mesh": false,
"settable_per_meshgroup": false,
"type": "float"
},
"machine_extruder_start_pos_abs":
{
"default_value": false,
Expand Down
Loading