kor_translation update #16916
Closed
kor_translation update #16916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: Community Contribution 👑
casperlamboo
requested changes
Nov 29, 2023
There was a problem hiding this comment.
Wow, massive PR. I don't speak Korean myself, but what I can judge from this it looks good. Since we have a commercial company doing our translations we have many many different people working on it, good to have a single person unifying the translations for us.
Had some remarks, not sure if they are all applicable for Korean.
Let me know if you have questions
Co-authored-by: Casper Lamboo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.