Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove convex hull computation when not required #16712

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Remove convex hull computation when not required #16712

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab22611
Remove convex hull computation when not required
wawanbreton Sep 11, 2023
80a8d86
Merge remote-tracking branch 'origin/main' into CURA-10004_fix_crash_…
wawanbreton Sep 11, 2023
e4a6b8d
Revert "Remove convex hull computation when not required"
wawanbreton Sep 18, 2023
9334447
Do not compute a convex hull for layer data nodes
wawanbreton Sep 18, 2023
47b4320
Merge branch 'main' into CURA-10004_fix_crash_small_rotations
saumyaj3 Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cura/PlatformPhysics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def _onChangeTimerFinished(self):
move_vector = move_vector.set(y = -bbox.bottom + z_offset)

# If there is no convex hull for the node, start calculating it and continue.
saumyaj3 marked this conversation as resolved.
Show resolved Hide resolved
if not node.getDecorator(ConvexHullDecorator) and not node.callDecoration("isNonPrintingMesh"):
if not node.getDecorator(ConvexHullDecorator) and not node.callDecoration("isNonPrintingMesh") and node.callDecoration("getLayerData") is None:
node.addDecorator(ConvexHullDecorator())

# only push away objects if this node is a printing mesh
Expand Down
Loading