-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Trimaker 3D printer profiles #16286
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/2)
"acceleration_wall": { "value": "math.ceil(acceleration_print * 1000 / 4000)" }, | ||
"acceleration_wall_0": { "value": "math.ceil(acceleration_wall * 500 / 1000)" }, | ||
"adhesion_type": { "default_value": "skirt" }, | ||
"cool_fan_enabled": { "default_value": true }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding cool_fan_enabled with the same value (default_value: True) as defined in parent definition: fdmprinter
"cool_fan_enabled": { "default_value": true }, | |
"acceleration_wall_0": { "value": "math.ceil(acceleration_wall * 500 / 1000)" }, | ||
"adhesion_type": { "default_value": "skirt" }, | ||
"cool_fan_enabled": { "default_value": true }, | ||
"cool_fan_speed": { "value": "100.0 if cool_fan_enabled else 0.0" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding cool_fan_speed with the same value (value: 100.0 if cool_fan_enabled else 0.0) as defined in parent definition: fdmprinter
"cool_fan_speed": { "value": "100.0 if cool_fan_enabled else 0.0" }, | |
"adhesion_type": { "default_value": "skirt" }, | ||
"cool_fan_enabled": { "default_value": true }, | ||
"cool_fan_speed": { "value": "100.0 if cool_fan_enabled else 0.0" }, | ||
"default_material_bed_temperature": { "default_value": 60 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding default_material_bed_temperature with the same value (default_value: 60) as defined in parent definition: fdmprinter
"default_material_bed_temperature": { "default_value": 60 }, | |
"infill_overlap": { "value": "0" }, | ||
"infill_pattern": { "value": "'gyroid'" }, | ||
"infill_sparse_density": { "default_value": 15 }, | ||
"infill_sparse_thickness": { "value": "resolveOrValue('layer_height')" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding infill_sparse_thickness with the same value (value: resolveOrValue(layer_height
)) as defined in parent definition: fdmprinter
"infill_sparse_thickness": { "value": "resolveOrValue('layer_height')" }, | |
"infill_sparse_density": { "default_value": 15 }, | ||
"infill_sparse_thickness": { "value": "resolveOrValue('layer_height')" }, | ||
"infill_wipe_dist": { "value": "0" }, | ||
"jerk_enabled": { "default_value": false }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding jerk_enabled with the same value (default_value: False) as defined in parent definition: fdmprinter
"jerk_enabled": { "default_value": false }, | |
"machine_start_gcode": { "default_value": ";Trimaker Nebula Start Code\n G21; Unidades en mm\n G90; Posicion absoluta\n M82; Extrusor en modo absoluto\n M107; Fan apagado\n G28 X Y Z; Enviamos a home a todos los ejes\n M900 K=0; Linear advance desactivado\n M104 S110; Precalentamos el extrusor hasta 110 grados\n M190 S{material_bed_temperature_layer_0};\n G29; Senso la cama\n M500\n G1 F5000 X0.5 Y0.5\n Calentamos cama y esperamos\n M109 S{material_print_temperature}; Calentamos extrusor y esperamos\n G92 E0; E=0\n G1 F200 X0.5 Y0.5 Z0.300\n G1 F900 X0.5 Y51.5 E2.56436; Hacemos una linea para limpiar extrusor\n" }, | ||
"machine_width": { "default_value": 230 }, | ||
"material_diameter": { "default_value": 1.75 }, | ||
"material_flow": { "value": 100 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding material_flow with the same value (value: 100) as defined in parent definition: fdmprinter
"material_flow": { "value": 100 }, | |
"material_flow": { "value": 100 }, | ||
"optimize_wall_printing_order": { "value": "True" }, | ||
"retraction_amount": { "default_value": 1 }, | ||
"retraction_enable": { "default_value": true }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding retraction_enable with the same value (default_value: True) as defined in parent definition: fdmprinter
"retraction_enable": { "default_value": true }, | |
"speed_travel": { "value": "speed_print if magic_spiralize else 100" }, | ||
"speed_wall_0": { "value": 35 }, | ||
"speed_wall_x": { "value": 45 }, | ||
"support_angle": { "default_value": 50 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding support_angle with the same value (default_value: 50) as defined in parent definition: fdmprinter
"support_angle": { "default_value": 50 }, | |
"speed_wall_x": { "value": 45 }, | ||
"support_angle": { "default_value": 50 }, | ||
"support_enable": { "default_value": true }, | ||
"support_pattern": { "default_value": "zigzag" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding support_pattern with the same value (default_value: zigzag) as defined in parent definition: fdmprinter
"support_pattern": { "default_value": "zigzag" }, | |
"support_angle": { "default_value": 50 }, | ||
"support_enable": { "default_value": true }, | ||
"support_pattern": { "default_value": "zigzag" }, | ||
"support_type": { "default_value": "everywhere" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding support_type with the same value (default_value: everywhere) as defined in parent definition: fdmprinter
"support_type": { "default_value": "everywhere" }, | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (2/2)
"support_enable": { "default_value": true }, | ||
"support_pattern": { "default_value": "zigzag" }, | ||
"support_type": { "default_value": "everywhere" }, | ||
"support_xy_distance": { "default_value": 0.7 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding support_xy_distance with the same value (default_value: 0.7) as defined in parent definition: fdmprinter
"support_xy_distance": { "default_value": 0.7 }, | |
"support_z_distance": { "default_value": 0.17 }, | ||
"top_bottom_thickness": { "value": "layer_height * 6" }, | ||
"wall_thickness": { "value": "line_width * 3" }, | ||
"xy_offset": { "default_value": 0 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding xy_offset with the same value (default_value: 0) as defined in parent definition: fdmprinter
"xy_offset": { "default_value": 0 }, | |
Greetings, we cannot understand why the tests are failing. Any assistance would be greatly appreciated. Thank you. |
changes in the end gcode
changes to the end gcode
changes to de end gcode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
@@ -78,4 +78,4 @@ | |||
"xy_offset": { "default_value": 0 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding xy_offset with the same value (default_value: 0) as defined in parent definition: fdmprinter
"xy_offset": { "default_value": 0 }, | |
@@ -121,4 +121,4 @@ | |||
"xy_offset": { "default_value": 0 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding xy_offset with the same value (default_value: 0) as defined in parent definition: fdmprinter
"xy_offset": { "default_value": 0 }, | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
@@ -121,4 +121,4 @@ | |||
"xy_offset": { "default_value": 0 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding xy_offset with the same value (default_value: 0) as defined in parent definition: fdmprinter
"xy_offset": { "default_value": 0 }, | |
se elimino xy_offset
se elimino xy_offset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
@@ -118,7 +118,6 @@ | |||
"support_z_distance": { "default_value": 0.17 }, | |||
"top_bottom_thickness": { "value": "layer_height * 6" }, | |||
"wall_thickness": { "value": "line_width * 3" }, | |||
"xy_offset": { "default_value": 0 }, | |||
"xy_offset_layer_0": { "value": -0.1 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding xy_offset with the same value (default_value: 0) as defined in parent definition: fdmprinter
"xy_offset_layer_0": { "value": -0.1 } | |
se elimina "xy_offset_layer_0": { "value": -0.1 }
Description
The Trimaker Nebula Cloud profile has been added to Cura.
Type of change
How Has This Been Tested?
The printer definition was tested for the last month in office with diferent 3D models to ensure it works correctly in diferents situations