Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creat new machine named Renkforce 10+ #15470

Merged
merged 43 commits into from
Aug 2, 2023
Merged

Creat new machine named Renkforce 10+ #15470

merged 43 commits into from
Aug 2, 2023

Conversation

goofoo3d
Copy link
Contributor

@goofoo3d goofoo3d commented May 8, 2023

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

Checklist:

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label May 8, 2023
@goofoo3d
Copy link
Contributor Author

goofoo3d commented Jul 7, 2023

What should I do next so we can be merged with Cura project?

@goofoo3d
Copy link
Contributor Author

Hello

@MariMakes MariMakes added the PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions label Jul 31, 2023
@MariMakes
Copy link
Contributor

Hi 👋

Sorry, it took us a while to get back to you 😞
We are a bit behind on these pull requests, I'll ask the developers to take a look as soon as there is time.

In the future, if you are stuck feel free to tag me 😉

@goofoo3d
Copy link
Contributor Author

goofoo3d commented Aug 2, 2023

Thank you!

@MariMakes
Copy link
Contributor

The PR looks good 😄, we are going to try to include it in the Cura 5.5 release 💪

@MariMakes MariMakes merged commit 596914c into Ultimaker:main Aug 2, 2023
@MariMakes
Copy link
Contributor

Hey @goofoo3d,

I apologize, I made an error. Our QA pointed me to something I've overlooked.
Your printer definition is based on https://github.com/Ultimaker/Cura/blob/main/resources/definitions/goofoo_near.def.json which only has quality files for a 0.4 mm nozzle.

So even though you defined multiple nozzle sizes, because there are no quality files that go with these nozzles, the user will get an error if they select them.
image (115)

Because the quality files are not available here for the printer this printer inherits from
https://github.com/Ultimaker/Cura/tree/main/resources/quality/goofoo

So I apologize but I acted too quickly and have to revert the pull request until you resolve this issue.

You can either:

  1. remove the extra variants, or
  2. Include tuned quality profiles for these nozzle sizes for Goofoo_base. You can take a look at how it is done for Creality 3D printers here: https://github.com/Ultimaker/Cura/tree/main/resources/quality/creality/base
  3. Remove the reference to goofoo_near and add quality files for only this Renkforce 10+

If you are stuck in any way feel free to reach out and I'll try to help you.

@MariMakes
Copy link
Contributor

Hey @goofoo3d,

Did you look at our change request, we cannot ship your suggested change.

You can either:

  1. remove the extra variants, or
  2. Include tuned quality profiles for these nozzle sizes for Goofoo_base. You can take a look at how it is done for Creality 3D printers here: https://github.com/Ultimaker/Cura/tree/main/resources/quality/creality/base
  3. Remove the reference to goofoo_near and add quality files for only this Renkforce 10+

Do you have a preference for one? Because than we can help you implement it.

@MariMakes MariMakes added the Status: Needs Info Needs more information before action can be taken. label Aug 14, 2023
@goofoo3d
Copy link
Contributor Author

I have reopened a pull request 'Tuned quality profiles #16481'. Please check it! Thks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions Status: Needs Info Needs more information before action can be taken.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants