Skip to content

Commit

Permalink
Merge branch '5.5' into CURA-10967_support-type-with-support-material
Browse files Browse the repository at this point in the history
  • Loading branch information
saumyaj3 authored Oct 5, 2023
2 parents 3552820 + 8c7e58d commit 51bc2a8
Show file tree
Hide file tree
Showing 103 changed files with 46 additions and 3,094 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/installers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,22 @@ jobs:
with:
name: ${{ steps.filename.outputs.LINUX }}-AppImage
path: installers

- name: Download linux installer jobs asc artifacts
uses: actions/download-artifact@v2
with:
name: ${{ steps.filename.outputs.LINUX }}-asc
path: installers

- name: Rename Linux installer to nightlies
run: |
mv installers/${{ steps.filename.outputs.LINUX }}.AppImage installers/${{ steps.filename.outputs.NIGHTLY_NAME }}-linux-X64.AppImage
mv installers/${{ steps.filename.outputs.LINUX }}.AppImage.asc installers/${{ steps.filename.outputs.NIGHTLY_NAME }}-linux-X64.AppImage.asc
- name: Update nightly release for Linux
run: |
gh release upload nightly installers/${{ steps.filename.outputs.NIGHTLY_NAME }}-linux-X64.AppImage --clobber
gh release upload nightly installers/${{ steps.filename.outputs.NIGHTLY_NAME }}-linux-X64.AppImage.asc --clobber
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,14 @@ jobs:
dist/${{ steps.filename.outputs.INSTALLER_FILENAME }}.AppImage
retention-days: 5

- name: Upload the asc
uses: actions/upload-artifact@v3
with:
name: ${{ steps.filename.outputs.INSTALLER_FILENAME }}-asc
path: |
dist/${{ steps.filename.outputs.INSTALLER_FILENAME }}.AppImage.asc
retention-days: 5

- name: Write the run info
shell: python
run: |
Expand Down
2 changes: 1 addition & 1 deletion cura/UI/ObjectsModel.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def __init__(self, parent = None) -> None:
self._group_name_template = catalog.i18nc("@label", "Group #{group_nr}")
self._group_name_prefix = self._group_name_template.split("#")[0]

self._naming_regex = re.compile("^(.+)\(([0-9]+)\)$")
self._naming_regex = re.compile(r"^(.+)\(([0-9]+)\)$")

def setActiveBuildPlate(self, nr: int) -> None:
if self._build_plate_number != nr:
Expand Down
4 changes: 2 additions & 2 deletions packaging/AppImage-builder/create_appimage.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def build_appimage(dist_path, version, appimage_filename):
"""
generate_appimage_builder_config(dist_path, version, appimage_filename)
create_appimage()
sign_appimage(dist_path, appimage_filename)
sign_appimage(appimage_filename)


def generate_appimage_builder_config(dist_path, version, appimage_filename):
Expand Down Expand Up @@ -85,7 +85,7 @@ def create_appimage():
raise RuntimeError(f"The AppImageTool command returned non-zero: {result}")


def sign_appimage(dist_path, appimage_filename):
def sign_appimage(appimage_filename):
command = ["gpg", "--yes", "--armor", "--detach-sig", appimage_filename]
result = subprocess.call(command)
if result != 0:
Expand Down
6 changes: 3 additions & 3 deletions resources/definitions/fdmprinter.def.json
Original file line number Diff line number Diff line change
Expand Up @@ -4534,7 +4534,7 @@
"type": "extruder",
"default_value": "0",
"value": "support_extruder_nr",
"enabled": "(support_enable or support_meshes_present) and extruders_enabled_count > 1",
"enabled": "(support_enable or support_meshes_present) and extruders_enabled_count > 1 and support_interface_enable",
"resolve": "max(extruderValues('support_interface_extruder_nr'))",
"settable_per_mesh": false,
"settable_per_extruder": false,
Expand All @@ -4547,7 +4547,7 @@
"type": "extruder",
"default_value": "0",
"value": "support_interface_extruder_nr",
"enabled": "(support_enable or support_meshes_present) and extruders_enabled_count > 1",
"enabled": "(support_enable or support_meshes_present) and extruders_enabled_count > 1 and support_roof_enable",
"resolve": "max(extruderValues('support_roof_extruder_nr'))",
"settable_per_mesh": false,
"settable_per_extruder": false
Expand All @@ -4559,7 +4559,7 @@
"type": "extruder",
"default_value": "0",
"value": "support_interface_extruder_nr",
"enabled": "(support_enable or support_meshes_present) and extruders_enabled_count > 1",
"enabled": "(support_enable or support_meshes_present) and extruders_enabled_count > 1 and support_bottom_enable",
"resolve": "max(extruderValues('support_bottom_extruder_nr'))",
"settable_per_mesh": false,
"settable_per_extruder": false
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 51bc2a8

Please sign in to comment.