Bugfixes related to inverse property labels #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A leftover select2 widget was overlaid on the Jasmine browser interface because I didn't do this originally.
This prevents a race condition where the select2 plugin might attempt to open a dropdown that no longer exists.
BeritJanssen
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that generated inverse properties were again (or still?) appearing without a label in the semantic search
Dropdownview. Fixing this led me through a short cascade of minor bugs due to oversights on my part. The commit list below tells the full story. The end result is that all traversals in the dropdown have labels "for real", a newisRdfPropertyutility function entered the scene, and a bunch of (regression) tests was added that now all pass without errors.I discovered the bug that started the cascade while working on #486. There existed no issues dedicated to the bugs I fixed, so I'm attaching this PR directly to the bug label and the project board.