Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search and exploration aspect #106

Closed
2 of 8 tasks
jgonggrijp opened this issue Aug 20, 2019 · 2 comments
Closed
2 of 8 tasks

Search and exploration aspect #106

jgonggrijp opened this issue Aug 20, 2019 · 2 comments
Assignees
@jgonggrijp
Labels
enhancement New feature or request
Milestone
Search

Comments

@jgonggrijp
Copy link
Member

jgonggrijp commented Aug 20, 2019 •
edited
Loading

Aspect module that connects event bindings between the following global instances:

The events to bind simply follow from intuition about what the application should do. For example, if you click on a featured item on the welcome page, the item in question should be displayed in the explorer and the route should reflect this change of context.
@jgonggrijp jgonggrijp added the enhancement New feature or request label Aug 20, 2019
This was referenced Aug 20, 2019
Open
Closed
@jgonggrijp jgonggrijp modified the milestones: Next presentation, Search Jun 10, 2020
@jgonggrijp jgonggrijp self-assigned this Jun 10, 2020
@jgonggrijp
Copy link
Member Author

I'll be partially implementing this alongside #62.

@jgonggrijp jgonggrijp mentioned this issue Jun 10, 2020
Closed
jgonggrijp added a commit that referenced this issue Jun 16, 2020
@jgonggrijp
Add a global instance of the exploration router (#62, #106)
aa6598a
jgonggrijp added a commit that referenced this issue Jun 16, 2020
@jgonggrijp
Stop passing around a complete ontology everywhere (#289)
905b6c9 
Now that we have a self-updating annotation editing panel, we finally
don't need to do all of that anymore. This brings us a step closer
to #106 and #62.
jgonggrijp added a commit that referenced this issue Jul 2, 2020
@jgonggrijp
Clean up the imports in the readit aspect (#289, #106)
0de5964
jgonggrijp added a commit that referenced this issue Jul 2, 2020
@jgonggrijp
Lift the explorer view into a global (#289 #106 #62)
4b08e21
jgonggrijp added a commit that referenced this issue Jul 2, 2020
@jgonggrijp
Drop a stray import (#106)
b5bead0
jgonggrijp added a commit that referenced this issue Jul 2, 2020
@jgonggrijp
Flatten (don't nest) the event bindings in the readit aspect (#106)
17f71f5
jgonggrijp added a commit that referenced this issue Jul 2, 2020
@jgonggrijp
Group bindings in the readit aspect by emitter (#106)
f690393
jgonggrijp added a commit that referenced this issue Jul 2, 2020
@jgonggrijp
Optimize line length in the readit aspect module (#106)
8a91316
jgonggrijp added a commit that referenced this issue Jul 2, 2020
@jgonggrijp
Factor account registration into a separate aspect (#106)
d2c2a29
jgonggrijp added a commit that referenced this issue Aug 12, 2020
@jgonggrijp
Replace global imports in unit modules (argh!) by event bindings
bf55948 
Related to #256, #260, #106.
jgonggrijp added a commit that referenced this issue Aug 12, 2020
@jgonggrijp
Merge obsolete directionFsm into userFsm (#256, #260, #106)
ba742a0 
DirectionFsm was supposed to be replaced by UserFsm long ago.
Hopefully, we'll now be rid of it forever.
jgonggrijp added a commit that referenced this issue Aug 12, 2020
@jgonggrijp
Rename DirectionRouter to MainRouter for clarity (#106)
f527a3a
jgonggrijp added a commit that referenced this issue Aug 12, 2020
@jgonggrijp
Rename "readit" aspect to "navigation" for clarity (#106)
e0dcda6
jgonggrijp added a commit that referenced this issue Aug 12, 2020
@jgonggrijp
Do some more cleanup in the navigation aspect (#106)
adbbc2b
jgonggrijp added a commit that referenced this issue Aug 12, 2020
@jgonggrijp
Rename "panel-explorer" directory to "explorer" (#106)
291e3b0 
After all, the explorer is not a panel!
jgonggrijp added a commit that referenced this issue Aug 12, 2020
@jgonggrijp
Remove circular dependency between explorer view and controller (#106)
ad8f25d
jgonggrijp added a commit that referenced this issue Aug 12, 2020
@jgonggrijp
Factor out route patterns from the exploration router (#62, #106)
788cb53
jgonggrijp added a commit that referenced this issue Aug 12, 2020
@jgonggrijp
Add a utility for self-reporting explorer routes in panels (#62, #106)
ea4d931
jgonggrijp added a commit that referenced this issue Aug 12, 2020
@jgonggrijp
Announce the current route from each panel on scroll (#62, #106)
1ff2ab1
jgonggrijp added a commit that referenced this issue Aug 13, 2020
@jgonggrijp
Add exploration aspect, navigate on scroll (#62, #106)
4525326
jgonggrijp added a commit that referenced this issue Aug 13, 2020
@jgonggrijp
Don't omit the margin on rightward scroll (#110 #271 #318 #62 #106)
11f1853 
Omitting that margin prevents the browser address bar from showing the
actual route.
jgonggrijp added a commit that referenced this issue Aug 13, 2020
@jgonggrijp
Scroll and navigate on every panel manipulation (#62, #106)
5737570 
This makes the behavior entirely consistent and reliable.
@jgonggrijp jgonggrijp mentioned this issue Aug 18, 2020
Closed
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Enable explorer scrolling by panel cid (#62, #106)
8dd593a
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Save the panel cid when navigating (#62, #106)
2332bfa
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Scroll to a previously visited panel on route (#62 #106)
091b28d
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Replace agnostic async check by gnostic sync check (#106)
42d7afa
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Add the option to reset the explorer entirely (#106 #62)
baa0a13
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Remove stray import from explorer controller module (#289 #106)
0502198
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Refactor the explorer event controller (#106 #289 #342)
7e0c6ee 
- Factor out common logic
- More consistent method names
- Shorter names
- Return created panel views where possible
- Return void otherwise
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Un-defer reopening the annotation list (#106 #289)
ee99717 
This has been unnecessary for a while.
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Move explorer controller event bindings to the aspect module (#106 #289)
4eb8c9c
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Add explorer view method for checking panel existence (#62 #106)
1c8ffba
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Attach the explorer when matching an explorer route (#62 #106)
881d7a0
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Add explorer event controller methods for reset options (#106)
2438797
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Add the explorer route parser (#62 #106)
080722a
jgonggrijp added a commit that referenced this issue Aug 19, 2020
@jgonggrijp
Reset the explorer when starting with a deep link (#106)
b33c8c6
@jgonggrijp jgonggrijp mentioned this issue Aug 19, 2020
Merged
jgonggrijp added a commit that referenced this issue Aug 20, 2020
@jgonggrijp
Allow hard routes in the announceRoute utility (#106 #62)
d4e3520
jgonggrijp added a commit that referenced this issue Aug 20, 2020
@jgonggrijp
Move ensureSources from the navigation to the exploration aspect (#106)
11baf89
jgonggrijp added a commit that referenced this issue Aug 20, 2020
@jgonggrijp
Enable scroll/reset on route for the source list panel (#62 #106)
9f12806
jgonggrijp added a commit that referenced this issue Aug 20, 2020
@jgonggrijp
Factor out the scrollOrAction pattern (#106)
ad0e492
jgonggrijp added a commit that referenced this issue Aug 20, 2020
@jgonggrijp
Replace route parser by a pattern that is easier on the brain (#62 #106)
d30ed09
jgonggrijp added a commit that referenced this issue Aug 20, 2020
@jgonggrijp
Reorder the exploration aspect module (#106)
2e8e872
@jgonggrijp
Copy link
Member Author

Closing this after #344, as insights about which objects should participate in which aspects have shifted somewhat over time. @BeritJanssen Feel free to create a separate aspect module for search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgonggrijp jgonggrijp

Labels
enhancement New feature or request
Projects
None yet
Milestone
Search
Development

No branches or pull requests
2 participants
@jgonggrijp @alexhebing