Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fernandezian13 checkbox bugfix #22

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fernandezian13
Copy link
Contributor

Made changes ensuring that file operations are working as discussed: checkboxes stay checked, goals don't duplicate as a consequence of the checkbox/completion not retaining itself, and that goals stored in the local goals.csv are able to be deleted.

Added updateGoalInCSV method updates the goal in the CSV file if it matches the existing goal's attributes. markGoalCompleted method now calls the new updateGoalInCSV method to update the goal's completion status in the CSV file, ensuring the state/checkbox persists.
Re-added the commented description block.
Addition of context constructor to call the updateGoalInCSV method to save the completion state of a goal when it is checked.
Adapter now has access to the context of the activity.
Copy link
Contributor

@Cambrian34 Cambrian34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants