Fix bug when to_gis() is called on a network with a leak #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaklise
reviewed
Nov 13, 2024
wntr/tests/test_network.py
Outdated
| junction_name = wn.junction_name_list[0] | ||
| junction = wn.get_node(junction_name) | ||
| junction.add_leak(wn, area=1, start_time=0, end_time=3600) | ||
| wn.to_dict() |
There was a problem hiding this comment.
I suggest adding from_dict to make sure the leak can be recreated in a water network model.
…creating geojsons instead.
dbhart
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the bug reported in #456.
Summary
to_dictmethod for controls so that the case when the target object is a Node can be handled._read_control_linefor Nodes. Previously only link elements were expected.from_dictTests and documentation
A test case is added that runs
to_dicton a network with a leak and verifies that the leak controls and attributes persist after the dictionary representation is read back in withfrom_dict.Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.