-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exceptions #381
Exceptions #381
Conversation
@kbonney I see you also have a PR in to do some work on Exceptions. I know that the request with MSX was that we somehow use the same error codes as EPANET does in wntr.epanet.msx.io, and I started setting that up for wntr.epanet.io also, but I think we did this in parallel and should try to merge our approaches. :-) |
Trim down (remove Enum) and create some tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaklise added tests for exceptions
Added documentation file, links to it, tests, and the files are now all up to date. |
Todo to finish this PR:
|
Summary
Provides updated EpanetException class and subclasses that allow for cleaner error reporting during IO.