-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Results and Control updates for testing and stepwise. #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbonney
changed the title
Adding results files to fresh branch
Results and Control updates for Stepwise
Oct 23, 2023
kbonney
changed the title
Results and Control updates for Stepwise
Results and Control updates for testing and stepwise.
Oct 23, 2023
TODO:
|
kbonney
commented
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull out reset/set initial conditions tests to separate test file
closing until we revist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_shift
method to Control base class and implemented on some sub classes- "Shift any SimTimeConditions within larger condition rules by value seconds (backward)."set_initial_conditions()
method added to water network model class which "Sets the initial conditions of the network based on prior simulation results." This method utilized the_shift
method defined above.Tests and documentation
Updates to result object are used to restructure
test_multiple_simuluations.py
, which has been split into the following files:test_stop_start_sim.py
: tests the use ofset_initial_conditions
to perform a simulation in multiple steps. (EpanetSim and WNTRSim).test_pickle_reset
: tests that results are consistent when pickling a water network and usingreset_initial_conditions
test_reset_initial_values
: tests thatreset_initial_values
gives approximately the same results before and after its use.Additionally, a test for the new results object was added in
test_results.py
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.