ROTM-80: Update Keycloak Image #252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adityababumallisettiHO
commented
Dec 13, 2023
adityababumallisettiHO
commented
- Replace Keycloak Image
* Replace Keycloak Image
* Fix the authorization issue
* Deployment uses client ID and secret from Secrets
* Use proxy redirection for all env's * Set to File vault URL
sulthan-ahmed
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Absolutely fantastic work @adityababumallisettiHO
Once it is tested. Can you squash it with the fact it was fixed by adding the tls version.
|
Can this image version be used with the old keycloak realm version? If not, do not merge it into master |
|
CI has failed |
* use new keycloakv22 realm url for branch, uat * use exisiting keycloak url for stage and prod * Wait for Keycloak migration for stage and prod
|
@adityababumallisettiHO great work just remember we can't merge this into master until ACP have put keycloak into prod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.