Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node v18 #239

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update to Node v18 #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b954530
add changes for node v18 upgrade
ChisomOguibe11 Mar 27, 2023
99b66dc
revert nginx image version number back to original
ChisomOguibe11 Mar 27, 2023
bf6e595
upgrade hof package to v20.2.3
ChisomOguibe11 Mar 27, 2023
4756a13
revert hof package version back to original
ChisomOguibe11 Mar 27, 2023
d3ec363
update express from v 4.17.1 to 4.17.3 - fix synk_scan vulnerability …
ChisomOguibe11 Mar 28, 2023
b3a0cda
synk_scan - update hof package from v19.14.13 to 19.14.17
ChisomOguibe11 Mar 28, 2023
aa63287
update yarn.lock
ChisomOguibe11 Mar 28, 2023
7046c7e
renew expiry dates for all vulnerabilities in .snyk file
ChisomOguibe11 Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ trigger:

linting: &linting
pull: if-not-exists
image: node:14
image: node:18
environment:
NOTIFY_KEY: USE_MOCK
commands:
- yarn run test:lint

unit_tests: &unit_tests
pull: if-not-exists
image: node:14
image: node:18
environment:
NOTIFY_KEY: USE_MOCK
commands:
Expand Down Expand Up @@ -70,7 +70,7 @@ steps:

- name: setup_deploy
pull: if-not-exists
image: node:14
image: node:18
environment:
NOTIFY_KEY: USE_MOCK
commands:
Expand Down Expand Up @@ -165,7 +165,7 @@ steps:

- name: setup_branch
pull: if-not-exists
image: node:14
image: node:18
environment:
NOTIFY_KEY: USE_MOCK
commands:
Expand Down Expand Up @@ -220,7 +220,7 @@ steps:
# Snyk & Anchore security scans which run after branch deployment to prevent blocking of PR UAT tests
- name: snyk_scan
pull: if-not-exists
image: node:14
image: node:18
environment:
SNYK_TOKEN:
from_secret: snyk_token
Expand Down Expand Up @@ -425,7 +425,7 @@ steps:

- name: cron_snyk_scan
pull: if-not-exists
image: node:14
image: node:18
environment:
SNYK_TOKEN:
from_secret: snyk_token
Expand Down
12 changes: 6 additions & 6 deletions .snyk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,27 @@ ignore:
SNYK-JS-USERAGENT-174737:
- device > useragent:
reason: No available patch currently in circulation
expires: '2022-11-01T17:02:21.865Z'
expires: '2023-11-01T17:02:21.865Z'
SNYK-JS-REQUEST-1314897:
- hof > request:
reason: Need to replace request in HOF
expires: '2022-09-18T14:58:46.388Z'
expires: '2023-09-18T14:58:46.388Z'
SNYK-JS-DICER-2311764:
- dicer:
reason: No upgrade path available at the moment
expires: '2022-07-28T11:12:26.000Z'
busboy-body-parser > busboy > dicer:
reason: No valid upgrade path
expires: '2022-12-01T15:05:28.958Z'
expires: '2023-12-01T15:05:28.958Z'
- busboy-body-parser > busboy > dicer:
reason: No upgrade path currently available
expires: '2022-07-28T11:28:19.289Z'
expires: '2023-07-28T11:28:19.289Z'
SNYK-JS-JPEGJS-2859218:
- '*':
reason: No upgrade or patch available
expires: '2022-11-01T17:02:21.865Z'
expires: '2023-11-01T17:02:21.865Z'
SNYK-JS-FILETYPE-2958042:
- jimp > @jimp/custom > @jimp/core > file-type:
reason: No valid upgrade path
expires: '2022-08-25T12:03:06.412Z'
expires: '2023-08-25T12:03:06.412Z'
patch: {}
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
FROM node:14-alpine@sha256:5c33bc6f021453ae2e393e6e20650a4df0a4737b1882d389f17069dc1933fdc5
FROM node:18-alpine@sha256:2322b1bb3917b313f2e9308395aa5c39d51b91cc92a5d4d5be6d0451fcfb4d24

USER root

# Update packages as a result of Anchore security vulnerability checks
RUN apk update && \
apk add --upgrade gnutls binutils nodejs nodejs-npm apk-tools libjpeg-turbo libcurl libx11 libxml2
apk add --upgrade gnutls binutils nodejs npm apk-tools libjpeg-turbo libcurl libx11 libxml2

# Setup nodejs group & nodejs user
RUN addgroup --system nodejs --gid 998 && \
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"description": "A Home Office application for reporting online terrorist material.",
"license": "GPL-2.0",
"engines": {
"node": "^14.15.0"
"node": "^18.12.1"
},
"repository": {
"type": "git",
Expand All @@ -29,9 +29,9 @@
"dependencies": {
"busboy-body-parser": "^0.3.2",
"device": "^0.3.12",
"express": "^4.17.1",
"express": "^4.17.3",
"govuk-frontend": "^3.13.0",
"hof": "^19.14.13",
"hof": "^19.14.17",
"jimp": "^0.16.1",
"jpeg-js": "^0.4.4",
"lodash": "^4.17.21",
Expand Down
Loading