Upgrade X-Gov 11ty plugin to version 6 and resolve breaking changes #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 27, 2023
1 task
keithkennedyHO
approved these changes
Jan 5, 2024
# Conflicts: # package.json
# Conflicts: # cypress/e2e/a11y.spec.cy.js
edhamiltonHO
approved these changes
Jan 5, 2024
2 tasks
oluashiruHO
pushed a commit
that referenced
this pull request
Jan 12, 2024
…360) * Update deps * Style config -> scss file * Phase banner border styling bug * Remove URL filter * update header config * Testing fixes * Update package-lock.json post merge from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code change
I can confirm:
Accessibility considerations
This upgrades X-Gov 11ty plugin to v6, which inlcudes changing to v5 of the gov.uk design system. Automated axe tests are passing, and a manual accessibility check on a sample of each layout used has been performed.
Upgrade guide: https://x-govuk.github.io/govuk-eleventy-plugin/upgrading/5-to-6/
urlfllter no longer needed