Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(351): add service reliability standard #352

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

oluashiruHO
Copy link
Contributor

Is this pull request a content or a code change? (Please fill in the relevant section and delete the other)

Code change

I can confirm:

Accessibility considerations

Content change

I can confirm:

  • Content does not include any code or configuration changes (excluding frontmatter information)
  • Content meets the content standards
    e.g. Writing a principle and Writing a standard
  • Content is suitable to open source, i.e.:
    • Content does not relate to unreleased gov policy
    • Content does not refer to anti-fraud mechanisms
    • Content does not include sensitive business logic
  • Last updated date for content is correct

@oluashiruHO oluashiruHO requested a review from a team as a code owner November 23, 2023 14:57
@daniel-ac-martin
Copy link
Contributor

I wonder whether this is really a single standard. (I defer to others on the definitions we are using.)

To me 'service reliability' is a goal that we are trying to achieve, rather than a specific standard. So I wonder if this should be broken down.

I also think this assumes that every service has a high availability requirement, which isn't really true. If we were to consider a back-end process (no human user), how many of these points remain as MUSTs?

@oluashiruHO oluashiruHO requested a review from a team as a code owner December 1, 2023 16:33
@robertdeniszczyc2
Copy link
Contributor

Hi,

I started providing feedback on this in the PR, but I think a lot of my thoughts are already captured by @daniel-ac-martin above (#352 (comment)).

Service reliability is already mentioned in the MaC Pattern and I feel some of the MUSTs in this feel closer to a Pattern than a Standard.

I'm happy to talk through in more detail, but I feel this needs some more refinement if it is to be implemented as a Standard.

Thanks,
Rob

Copy link

@LDP0wer LDP0wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've add comments from MBTP perspective. There's some lines in here which were explicitly to support QAT testing these Standards, which we won't need. Also offered rewording suggestions where our original wording was a bit clunky.

docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
Copy link

@LDP0wer LDP0wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments on small formatting/grammar suggestions.

docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
@oluashiruHO oluashiruHO reopened this Jan 12, 2024
@oluashiruHO oluashiruHO force-pushed the 351-service-reliability-standard branch from f0c3740 to 5d1ea27 Compare January 12, 2024 19:00
@jeff-horton-ho-sas jeff-horton-ho-sas added content Build release deploy Relates to BRD guild content Observability Relates to observability guild content labels Mar 8, 2024
Copy link
Contributor

@jeff-horton-ho-sas jeff-horton-ho-sas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
docs/standards/service-reliability.md Outdated Show resolved Hide resolved
@edhamiltonHO edhamiltonHO linked an issue Apr 26, 2024 that may be closed by this pull request
3 tasks
@jeff-horton-ho-sas jeff-horton-ho-sas force-pushed the 351-service-reliability-standard branch from ea7d48b to 37ffa09 Compare April 26, 2024 13:09
@edhamiltonHO edhamiltonHO merged commit 798e8ee into main Apr 26, 2024
3 checks passed
@edhamiltonHO edhamiltonHO deleted the 351-service-reliability-standard branch April 26, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build release deploy Relates to BRD guild content content Observability Relates to observability guild content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create standard for Service Reliability
8 participants