Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook Refactor + Mui Stories #50

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Storybook Refactor + Mui Stories #50

merged 2 commits into from
Nov 21, 2024

Conversation

jacksonhyde
Copy link
Collaborator

@jacksonhyde jacksonhyde commented Nov 21, 2024

  • Re-exports Mui components for storybook: The new *.component.tsx files are here only for storybook. Without rexporting them, tag names aren't properly set in code snippets and everything ends up as a React.forwardRef. These exports are only used in storybook, any application that uses drt-react should import Mui components from the mui libraries as normal.
  • Introduces .mdx documentation pages - see for an example of written component documentation
  • Adds Theme Variables page
  • Pulls Mui props into story controls
  • Moves Mui-X localisation adaptor up out of individual test scope

Copy link
Contributor

@richbirch richbirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty clean to me!

@jacksonhyde jacksonhyde merged commit 15e2933 into main Nov 21, 2024
2 checks passed
@jacksonhyde jacksonhyde deleted the form-input-stories branch November 21, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants