Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Failing Build on scan-app Action #586

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jremes-ho
Copy link
Contributor

Good afternoon.

"Scan service for vulnerabilities" workflow was failing because owasp/zap2docker Docker image does not exist any longer, it has been deprecated and replaced with owasp/zaproxy image with following error:

Error response from daemon: pull access denied for owasp/zap2docker, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

I have upgraded two actions in this workflow:

  • zaproxy/action-baseline (v0.4.0 -> v0.10.0)
  • zaproxy/action-full-scan (v0.7.0 -> v0.12.0)

This should fix the failing scan.

Thank you.

@jremes-ho jremes-ho added bug dependencies Pull requests that update a dependency file labels Jun 21, 2024
@daniel-ac-martin
Copy link
Collaborator

Thanks again @jremes-ho.

I should have noticed and pulled in the update from upstream: https://github.com/daniel-ac-martin/NotGovUK/blob/master/.github/actions/scan-app/action.yml

@daniel-ac-martin daniel-ac-martin merged commit 622a167 into master Jun 21, 2024
17 checks passed
@daniel-ac-martin daniel-ac-martin deleted the fix-failing-scan-zaproxy branch June 21, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants