Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header component styling issues #354

Closed
anandamaryon-gov opened this issue Apr 6, 2022 · 2 comments
Closed

Header component styling issues #354

anandamaryon-gov opened this issue Apr 6, 2022 · 2 comments

Comments

@anandamaryon-gov
Copy link

Details of a few styling issues I've noticed whilst working with the header component (https://design.homeoffice.gov.uk/components?name=Header). I am grouping them because they are mostly very minor (happy to split them up if more helpful).

  1. Navigation tabs move around when the active tab changes, due to the bold styling. This is visually distracting but also means that there is the possibility of the layout shifting on navigation, due to the maximum width being hit, and a tab reflowing to the next line.
    Suggested fix: remove the bold styling on active.

  2. The black underline which highlights when a tab is the current active tab, and shows on hover/focus states, is not a clickable part of the nav link. This can cause users to click on what they think is the tab, but their click will not initiate the expected change in navigation.
    Suggested fix: Move the active styling's border bottom from the list tag and on to the anchor tag.

  3. Account and sign out links (continued within the hods-header__account-menu element) are not right-aligned. This makes the header appear not centred and makes the account menu items hug closer to the service name.
    Suggested fix: remove the margin-right: auto; from this element.

  4. The header isn't very responsive, resulting in there being insufficient space between the service name and account menu items, which are both clickable and so would benefit from having space around them, to reduce erroneously selecting the wrong option. Spacing would also help readability.
    Suggested quick fix: Add some margin around the service name.

FYI for anyone who picks this up, other issues related to the header:

@anandamaryon-gov
Copy link
Author

I don't seem to have permission to edit Labels, so if anyone else can, please feel free to change these.

@daniel-ac-martin
Copy link
Collaborator

Thanks @anandamaryon-gov.

I'm going to move this to discussions. Once we know what we are going to do, we should break this down into smaller issues to be addressed.

@UKHomeOffice UKHomeOffice locked and limited conversation to collaborators Apr 25, 2022
@daniel-ac-martin daniel-ac-martin converted this issue into discussion #373 Apr 25, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants