Header component styling issues #373
Replies: 3 comments
-
I don't seem to have permission to edit Labels, so if anyone else can, please feel free to change these. |
Beta Was this translation helpful? Give feedback.
-
Thanks @anandamaryon-gov. I'm going to move this to discussions. Once we know what we are going to do, we should break this down into smaller issues to be addressed. |
Beta Was this translation helpful? Give feedback.
-
No bold for active state of link. The styling has also moved to the link rather than the button (though you can't see that on the image) The styling that produced these images is Header.txt. |
Beta Was this translation helpful? Give feedback.
-
Details of a few styling issues I've noticed whilst working with the header component (https://design.homeoffice.gov.uk/components?name=Header). I am grouping them because they are mostly very minor (happy to split them up if more helpful).
Navigation tabs move around when the active tab changes, due to the bold styling. This is visually distracting but also means that there is the possibility of the layout shifting on navigation, due to the maximum width being hit, and a tab reflowing to the next line.
Suggested fix: remove the bold styling on active.
The black underline which highlights when a tab is the current active tab, and shows on hover/focus states, is not a clickable part of the nav link. This can cause users to click on what they think is the tab, but their click will not initiate the expected change in navigation.
Suggested fix: Move the active styling's border bottom from the list tag and on to the anchor tag.
Account and sign out links (continued within the
hods-header__account-menu
element) are not right-aligned. This makes the header appear not centred and makes the account menu items hug closer to the service name.Suggested fix: remove the
margin-right: auto;
from this element.The header isn't very responsive, resulting in there being insufficient space between the service name and account menu items, which are both clickable and so would benefit from having space around them, to reduce erroneously selecting the wrong option. Spacing would also help readability.
Suggested quick fix: Add some margin around the service name.
FYI for anyone who picks this up, other issues related to the header:
Beta Was this translation helpful? Give feedback.
All reactions