Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCL-438 adding kms policy to key #175

Closed
wants to merge 4 commits into from
Closed

CCL-438 adding kms policy to key #175

wants to merge 4 commits into from

Conversation

mynampatinaveen
Copy link
Contributor

No description provided.

Copy link

@jremes-ho jremes-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion.

modules/products/static-site/kms.tf Outdated Show resolved Hide resolved
@jremes-ho jremes-ho self-requested a review September 9, 2024 09:15
Copy link

@jremes-ho jremes-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@mynampatinaveen mynampatinaveen enabled auto-merge (squash) September 9, 2024 09:18
@mynampatinaveen mynampatinaveen enabled auto-merge (squash) September 9, 2024 09:22
@jremes-ho jremes-ho self-requested a review September 9, 2024 09:26
Copy link

@jremes-ho jremes-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved.

@mynampatinaveen mynampatinaveen deleted the CCL-438 branch September 9, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants