Spike owasp zap #730
Open
Spike owasp zap #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed fork as fork was casuing double issue, due historical value. Also added backLink to '/letter-lost' to send user back to prev page apps/not-arrived/behaviours/letter-received.js Aded check to see if letter lost is true, if so branch to letter-lost otherwise continue to same-address. test/_unit/apps/not-arrived/behaviours/letter-recieved.spec.js Added unit test to check to see if branch logic in behaviour is working as intended.
Upgraded hof to latest version 19.14.1 index.js & letter-received.js reverted to version in master letter-received.spec.js Removed unit test that asserts branch = /letter-lost as this has been fixed in the hof controller so it has been reverted.
…forms into spike-owasp-zap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just testing zap in pipeline