BRP-71 - Fixed the way we handle field truncation #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me |
MCrawleyHomeOffice
changed the title
MCrawleyHomeOffice
force-pushed
the
BRP-71-Birth-Place-Truncation
branch
from
d17a8ba to
0711341
Compare
MCrawleyHomeOffice
force-pushed
the
BRP-71-Birth-Place-Truncation
branch
from
22491de to
383eff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There is a bug in the birth-place truncation logic whereby the max 16 characters is ignored and instead it always shows as if the max length is 30 characters. We have fixed this by introducing a new property called "max" which we pass all the way down to the template, and we have adjusted the template to show the new field.
Why?
Without this we would have been unable to display the correct error message
How?
Added a new max property to the session, added an extra paragraph in the error message object and adjusted the template accordingly.
Testing?
Tested locally
Screenshots (optional)
Anything Else?