Brp-61 - Additional Application type question on all BRP forms #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rhodine-orleans-lindsay
force-pushed
the
BRP-61
branch
17 times, most recently
from
3697064 to
2763851
Compare
Rhodine-orleans-lindsay
changed the title
| }; | ||
| }, | ||
| '/someone-else': data => { | ||
| return { | ||
| template: 'someone-else', | ||
| subject: 'Form submitted: Report someone else collecting your BRP. Ref: ' + setRef(data) | ||
| subject: 'Form submitted: Report someone else collecting your BRP. Ref: ' + setRef(data) + | ||
| ' (Application Type: ' + appType(data) + ')' | ||
| }; | ||
| } | ||
| }; |
There was a problem hiding this comment.
this looks good, perhaps you can just talk me through it :)
There was a problem hiding this comment.
this looks great @rhodine I'll be honest, it's super long, it might be easy just to go through it quickly in a call :)
Rhodine-orleans-lindsay
force-pushed
the
BRP-61
branch
4 times, most recently
from
032cf4d to
a3a72c3
Compare
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
oooh nice work @rhodine I prefer these tests rather than lots of acceptance tests which are slow and cause build issues ⭐
sulthan-ahmed
approved these changes
May 12, 2022
Rhodine-orleans-lindsay
force-pushed
the
BRP-61
branch
13 times, most recently
from
935ea13 to
4cf2974
Compare
Rhodine-orleans-lindsay
force-pushed
the
BRP-61
branch
4 times, most recently
from
9e682e9 to
8be2978
Compare
Rhodine-orleans-lindsay
force-pushed
the
BRP-61
branch
4 times, most recently
from
dde4c47 to
1220f52
Compare
* add application type to email subject header * add unit tests * add character limit for 'other' freetext
Rhodine-orleans-lindsay
force-pushed
the
BRP-61
branch
from
1220f52 to
b7c010b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing?
Tested locally
Screenshots (optional)
Anything Else?