Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRP-58 #712

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

BRP-58 #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
793c08e
Move post option to the end of the page on all journeys
Apr 7, 2022
4b56555
Update to latest version of hof
Apr 11, 2022
bf857a3
Merge branch 'master' into BRP-58
hjvoid Apr 11, 2022
57cef55
Update acceptance test on correct mistakes journey to reflect update …
Apr 11, 2022
9333104
Merge branch 'BRP-58' of https://github.com/hjvoid/brp_enquiry_forms …
Apr 11, 2022
19c4884
Update hof to 19.13.13
Apr 12, 2022
e0bd838
Updating hof to 19.13.14
Apr 14, 2022
da6a329
Update hof and snyk file
Apr 14, 2022
06a82c8
Add async to snyk file
Apr 14, 2022
2aa141d
Removing async from snyk file
Apr 14, 2022
306ad8e
Merge branch 'master' into BRP-58
hjvoid Apr 14, 2022
f21e330
Update winston to latest version and change logger file
Apr 14, 2022
1330fac
Add hof > mkdirp to snyk
Apr 14, 2022
6a788d4
Add browserify > subarg > minimist to snyk file
Apr 19, 2022
2f4e93a
Add browserify > browserify > deps-sort > subarg > minimist to snyk file
Apr 19, 2022
38d5828
Add hof > browserify > module-deps > subarg > minimist to snyk file
Apr 19, 2022
f677644
Add hof > browserify > module-deps > detective > minimist to snyk file
Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 13 additions & 20 deletions .snyk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,26 +35,19 @@ ignore:
reason: No update currently available
expires: '2022-02-20T10:38:20.144Z'
SNYK-JS-MINIMIST-2429795:
- hof > minimist:
reaason: Waiting for the package to be updated 1.2.6 in hof
expires: '2022-04-20T10:38:20.144Z'
- hof > mkdirp > minimist:
reaason: Waiting for the package to be updated 1.2.6 in hof
expires: '2022-04-20T10:38:20.144Z'
reason: mkdirp update currently crashing hof build
expires: '2022-04-22T10:38:20.144Z'
- hof > browserify > subarg > minimist:
reaason: Waiting for the package to be updated 1.2.6 in hof
expires: '2022-04-20T10:38:20.144Z'
- hof > browserify > deps-sort > subarg:
reaason: Waiting for the package to be updated 1.2.6 in hof
expires: '2022-04-20T10:38:20.144Z'
- hof > browserify > module-deps > subarg:
reaason: Waiting for the package to be updated 1.2.6 in hof
expires: '2022-04-20T10:38:20.144Z'
- hof > browserify > module-deps > detective:
reaason: Waiting for the package to be updated 1.2.6 in hof
expires: '2022-04-20T10:38:20.144Z'
SNYK-JS-ASYNC-2441827:
- '*':
reason: Needs async to be upgraded to 3.2.2 or higher in hof
expires: '2022-04-20T10:38:20.144Z'
reason: No update to browserify currently available
expires: '2022-04-24T16:53:44.487Z'
- hof > browserify > deps-sort > subarg > minimist:
reason: No update to browserify currently available
expires: '2022-04-24T16:53:44.487Z'
- hof > browserify > module-deps > subarg > minimist:
reason: No update to browserify currently available
expires: '2022-04-24T16:53:44.487Z'
- hof > browserify > module-deps > detective > minimist:
reason: No update to browserify currently available
expires: '2022-04-24T16:53:44.487Z'
patch: {}
4 changes: 2 additions & 2 deletions apps/collection/views/contact-details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@

{{#input-text}}email{{/input-text}}

{{#input-phone}}phone{{/input-phone}}

{{#checkbox}}use-address{{/checkbox}}

<fieldset id="address-group" class="panel-indent js-hidden">
Expand Down Expand Up @@ -65,8 +67,6 @@

</fieldset>

{{#input-phone}}phone{{/input-phone}}

{{#input-submit}}continue{{/input-submit}}

{{/form}}
Expand Down
4 changes: 2 additions & 2 deletions apps/correct-mistakes/views/contact-details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@

{{#input-text}}email{{/input-text}}

{{#input-phone}}phone{{/input-phone}}

{{#checkbox}}use-address{{/checkbox}}

<fieldset id="address-group" class="panel-indent js-hidden">
Expand Down Expand Up @@ -65,8 +67,6 @@

</fieldset>

{{#input-phone}}phone{{/input-phone}}

{{#input-submit}}continue{{/input-submit}}

{{/form}}
Expand Down
4 changes: 2 additions & 2 deletions apps/lost-stolen/views/contact-details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@

{{#input-text}}email{{/input-text}}

{{#input-phone}}phone{{/input-phone}}

{{#location.inside-uk}}
{{#checkbox}}use-address{{/checkbox}}

Expand Down Expand Up @@ -67,8 +69,6 @@
</fieldset>
{{/location.inside-uk}}

{{#input-phone}}phone{{/input-phone}}

{{#input-submit}}continue{{/input-submit}}

{{/form}}
Expand Down
4 changes: 2 additions & 2 deletions apps/not-arrived/views/contact-details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@

{{#input-text}}email{{/input-text}}

{{#input-phone}}phone{{/input-phone}}

{{#checkbox}}use-address{{/checkbox}}

<fieldset id="address-group" class="panel-indent js-hidden">
Expand Down Expand Up @@ -65,8 +67,6 @@

</fieldset>

{{#input-phone}}phone{{/input-phone}}

{{#input-submit}}continue{{/input-submit}}

{{/form}}
Expand Down
4 changes: 2 additions & 2 deletions apps/someone-else/views/contact-details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@

{{#input-text}}email{{/input-text}}

{{#input-phone}}phone{{/input-phone}}

{{#checkbox}}use-address{{/checkbox}}

<fieldset id="address-group" class="panel-indent js-hidden">
Expand Down Expand Up @@ -65,8 +67,6 @@

</fieldset>

{{#input-phone}}phone{{/input-phone}}

{{#input-submit}}continue{{/input-submit}}

{{/form}}
Expand Down
2 changes: 1 addition & 1 deletion lib/logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ if (notProd) {
delete transports.exceptionHandlers;
}

const logger = new (winston.Logger)(transports);
const logger = new winston.createLogger(transports);

winston.addColors(colors);

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"author": "HomeOffice",
"dependencies": {
"express": "^4.17.1",
"hof": "^19.13.12",
"hof": "^19.13.15",
"hogan.js": "^3.0.2",
"hot-shots": "^5.9.0",
"i18n-future": "^2.0.1",
Expand All @@ -36,7 +36,7 @@
"nodemailer": "^6.4.16",
"typeahead-aria": "^1.0.1",
"underscore": "^1.13.1",
"winston": "^1.0.1"
"winston": "^3.7.1"
},
"devDependencies": {
"@cucumber/cucumber": "^7.3.0",
Expand Down
Loading