Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asl-4629-endangered-cited #1666

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

parvinba
Copy link
Contributor

No description provided.

@parvinba parvinba requested a review from a team December 11, 2024 12:45
pages/rops/update/schema/index.js Outdated Show resolved Hide resolved
pages/rops/update/schema/index.js Outdated Show resolved Hide resolved
@parvinba parvinba requested review from jeff-horton-ho-sas and a team December 11, 2024 13:10
@jeff-horton-ho-sas
Copy link
Contributor

Copying this out of thread so it doesn't get lost:

https://github.com/UKHomeOffice/react-components/blob/main/src/forms/radio-group.jsx#L72-L75

This should either be renamed to disabledWarning or it should always display the warning an the warning is only passed if needed, i.e.

{
    opt.warning &&
    <div className="govuk-reveal">
        <Warning>{opt.warning}</Warning>
    </div>
}

I think I prefer the second option as it makes it possible to have warnings that always show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants