Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACRS-211-Bugfix For over 1500 characters #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TemitopeAyokuHO
Copy link
Contributor

@TemitopeAyokuHO TemitopeAyokuHO commented Jul 23, 2024

What?

ACRS-211. - known Error sometimes when over 15000 characters entered

Why?

When user enters more than 1500 characters in any textbox that requires max length of 1500, validation error message is not triggered instead a payload too large error appears once click on save and continue button.

Change of HOF Version 20.5.2

Changes of HOF Version 20.6.0

How?

  • I have added this changes to HOF framework version :
    21.0.1 and 20.5.7-Beta-payload-too-large.

  • Added two variable in the config.js to allow a dynamic body parser size be increased by developer.

Testing?

Tested manually on local machine

Screenshots (optional)

Screenshot 2024-07-22 at 16 35 44 Screenshot 2024-07-22 at 16 35 58

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

@TemitopeAyokuHO TemitopeAyokuHO self-assigned this Jul 23, 2024
@TemitopeAyokuHO TemitopeAyokuHO force-pushed the ACRS-211-Bugfix-over-15000-character-error branch 4 times, most recently from 5e490d9 to ce01fec Compare July 24, 2024 12:30
@TemitopeAyokuHO TemitopeAyokuHO requested review from dk4g and Rhodine-orleans-lindsay and removed request for jamiecarterHO and michaelhartHO July 24, 2024 12:32
-  I have added this changes to HOF framework version :
 21.0.1 and 20.5.7-Beta-payload-too-large.

-  Added two variable in the config.js to allow a dynamic body parser size be increased by developer.
@TemitopeAyokuHO TemitopeAyokuHO force-pushed the ACRS-211-Bugfix-over-15000-character-error branch from ce01fec to cdecde2 Compare July 24, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant