Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Refactor) Ensure that Infant status outcomes show for infants on the infant banner #1935

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

lucyjemutai
Copy link
Contributor

…nt banner

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

this pr does the following;

  1. code refactor
  2. Ensures the Infant status outcomes shows on infant banner.

Screenshots

Screenshot 2024-11-27 at 14 53 03 Screenshot 2024-11-27 at 14 53 55

Related Issue

Other

@lucyjemutai lucyjemutai marked this pull request as ready for review November 27, 2024 11:57
isLoading: false,
isError: false,
});

render(<PatientStatusBannerTag patientUuid={hivPositiveSampleUuid} />);
expect(screen.getByText('HIV Negative')).toBeInTheDocument();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucyjemutai , you can also add in other props and see if the values will be validated

'Still in Care': 'green',
'HIV negative infant discharged from PMTCT': 'green',
'Lost to followup': 'red',
Dead: 'red',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come Dead is not a string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other outcomes have spaces, so wrapping them in quotes makes them valid string keys.

I have updated the Dead outcome for consistency.

@ODORA0 ODORA0 changed the title code refactor and ensure that Infant status outcomes showing on infa… (Refactor) Ensure that Infant status outcomes show for infants on the infant banner Dec 2, 2024
@ODORA0 ODORA0 merged commit b05947d into UCSF-IGHS:dev Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants