-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-4052: Wrap SideNavMenu title in t function #1928
Conversation
@ibacher @CynthiaKamau requesting for a review, can't seem to be able to do it on the UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NethmiRodrigo , please fix the build errors
aea5c4f
to
8b929a1
Compare
@CynthiaKamau I updated the yarn.lock again, could you please approve the workflows, thanks. |
Maybe an obvious question but: Why do we need to work in here instead of in the OpenMRS repo: https://github.com/openmrs/openmrs-content-hiv |
@gracepotma this PR was to make the string that shows up in the navbar translatable, so its not a part of the content but rather a fix to the implementation. |
@CynthiaKamau I updated the |
@CynthiaKamau |
@CynthiaKamau the e2e test was failing because the defaultLocale was set to French in the instance, I've changed it back to English and it passes locally, could you re-run the workflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NethmiRodrigo
Thanks for reviewing @CynthiaKamau, could you please merge this in, I don't have the permission to do so. |
Done |
Requirements
OHRI-123 My PR title
.Summary
When there is a grouped link the NavBarMenu title does not get translated. This PR fixes that by wrapping the title in the
t
function.Screenshots
After fix:
Before fix:
Related Issue
https://ohri.atlassian.net/browse/O3-4052
Other
I had to upgrade the openmrs framework version which is why I included the yarn.lock.