-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting Demo #1910
Reporting Demo #1910
Conversation
…estoring the 'COVID' tab on the dasshboard affects routing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TrevorAntony , please undo the changes in the yarn.lock
and package.json
file
label="Select a report to display" | ||
items={[ | ||
{ id: 'ecabd559-14f6-4c65-87af-1254dfdf1304', text: 'Covid-19 Report' }, | ||
{ id: '3ffa5a53-fc65-4a1e-a434-46dbcf1c2de2', text: 'HTS Report' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add these uuids in the config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made the requested changes. kindly check new commit
Thanks @TrevorAntony, please look at the build failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some visual feedback,
- Could you leave a padding left before the reports dropdown and the fetch button.
- Green for table headers looks too much 🤔
@TrevorAntony following our sync earlier here is some feedback we talked about, let me know if you need any assistance
|
@TrevorAntony let's close this |
closed. But i wont delete the branch for now
…On Fri, 26 Jul 2024 at 09:28, kyampeire Hadijah ***@***.***> wrote:
@TrevorAntony <https://github.com/TrevorAntony> let's close this
—
Reply to this email directly, view it on GitHub
<#1910 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOXLNJTIH3CSX3XUYJKFP6TZOHT7LAVCNFSM6AAAAABLKU475WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJSGA3DGMZXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I have updated the PR