feat: parsing implemented. logout command implemented

src/main.rs

@@ -49,12 +49,22 @@ fn main() {
 
     match matches.subcommand() {
         Some(("login", sub_matches)) => {
-            let login_command = LoginSubcommand { };
-            login_command.execute(sub_matches);
+            let mut login_command = LoginSubcommand::new();
+            if login_command.parse_args(sub_matches).is_some() {
+                login_command.execute();
+            }
+            else {
+                // TODO: We failed processing
+            }
         },
         Some(("logout", sub_matches)) => {
-            let logout_command = LogoutSubcommand { };
-            logout_command.execute(sub_matches);
+            let mut logout_command = LogoutSubcommand::new();
+            if logout_command.parse_args(sub_matches).is_some() {
+                logout_command.execute();
+            }
+            else {
+                // TODO: We failed processing
+            }
         }
         _ => println!("No subcommand")
     }

src/subcommands/login_subcommand.rs

@@ -4,11 +4,24 @@ use crate::subcommands::Subcommand;
 use crate::credential_manager::CredentialManager;
 
 pub struct LoginSubcommand {
-
+    url: String,
+    user: String
 }
 
 impl LoginSubcommand {
-    fn login(user: &str, url: &str) {
+    pub fn new() -> LoginSubcommand {
+        LoginSubcommand {
+            url: "".to_string(),
+            user: "".to_string()
+        }
+    }
+}
+
+impl Subcommand for LoginSubcommand {
+    fn execute(&self) {
+        let url = self.url.as_str();
+        let user = self.user.as_str();
+
         let credential_manager = CredentialManager { };
 
         if credential_manager.has_credential(url) {
@@ -23,10 +36,14 @@ impl LoginSubcommand {
 
         // else throw error
     }
-}
 
-impl Subcommand for LoginSubcommand {
-    fn execute(&self, arg_matches: &ArgMatches) {
+    fn parse_args(&mut self, arg_matches: &ArgMatches) -> Option<()> {
+        let url = arg_matches.get_one::<String>("URL")?;
+        let user = arg_matches.get_one::<String>("USER")?;
+
+        self.url = url.clone();
+        self.user = user.clone();
 
+        Some(())
     }
 }

src/subcommands/logout_subcommand.rs

@@ -2,21 +2,34 @@ use crate::subcommands::subcommand::Subcommand;
 use crate::credential_manager::CredentialManager;
 
 pub struct LogoutSubcommand {
-
+    url: String
 }
 
 impl LogoutSubcommand {
-    fn logout(url: &str) {
+    pub fn new() -> LogoutSubcommand {
+        // Intentionally pass an empty string instead of using Some.
+        // Url is required and will be handled by parsing.
+        // We will still check during execution to see if the url is set just in case.
+        LogoutSubcommand {
+            url: "".to_string()
+        }
+    }
+}
+
+impl Subcommand for LogoutSubcommand {
+    fn execute(&self) {
+        let url = self.url.as_str();
         let credential_manager = CredentialManager { };
 
         if credential_manager.has_credential(url) {
             credential_manager.remove_credential(url);
         }
     }
-}
 
-impl Subcommand for LogoutSubcommand {
-    fn execute(&self, arg_matches: &clap::ArgMatches) {
-
+    fn parse_args(&mut self, arg_matches: &clap::ArgMatches) -> Option<()> {
+        let url = arg_matches.get_one::<String>("URL")?;
+        self.url = url.clone();
+
+        Some(())
     }
 }

src/subcommands/subcommand.rs

@@ -1,5 +1,6 @@
 use clap::ArgMatches;
 
 pub trait Subcommand {
-    fn execute(&self, arg_matches: &ArgMatches);
+    fn execute(&self);
+    fn parse_args(&mut self, arg_matches: &ArgMatches) -> Option<()>;
 }