Tidy up repo before first release #1

p-j-smith · 2023-10-20T09:56:20Z

use the mirsg pre-commit and renovate configs
use the mirsg linting and molecule-test actions
remove the empty handlers directory
use flat names for variables rather than nested

and run linters on all files

drmatthews

Many thanks for tidying up and getting this up-to-date @p-j-smith!

drmatthews · 2023-10-20T10:54:00Z

molecule/resources/converge.yml

@@ -6,7 +6,7 @@

  pre_tasks:


Unfortunately I left a mistake on line 18:

failed_when: systemctl_status.rc > 1

Should be:

failed_when: systemctl_status.rc > 0

thanks for spotting that! I'll fix now

paddyroddy

One action change

.github/workflows/add-issue-to-project.yml

Co-authored-by: Patrick Roddy <[email protected]>

drmatthews

👍

p-j-smith added 10 commits October 19, 2023 17:00

use mirsg pre-commit meta hook

46e4531

and run linters on all files

Use the mirsg linting and molecule-test actions

27a6be4

make renovate json config hidden file

892f410

Use mirsg renovate config

32c050e

remove empty handlers directory

c3d0239

use flat names for variables rather than nested

b309ebc

Use latest version of mirsg actions

e173599

remove ansible requirements path from linting action

34e2dc3

run pre-commit on all files

1add862

Add workflow to add opened issues to mirsg project board

cf8ec76

p-j-smith force-pushed the use-mirsg-configs branch from 0e0b8e1 to cf8ec76 Compare October 20, 2023 10:38

p-j-smith requested a review from a team October 20, 2023 10:44

drmatthews suggested changes Oct 20, 2023

View reviewed changes

paddyroddy self-requested a review October 20, 2023 10:58

paddyroddy suggested changes Oct 20, 2023

View reviewed changes

.github/workflows/add-issue-to-project.yml Outdated Show resolved Hide resolved

p-j-smith and others added 2 commits October 20, 2023 12:01

Fix add-issue-to-projcet action inputs

dfa4223

Co-authored-by: Patrick Roddy <[email protected]>

Fix failed_when statement for role pre-tasks

1fb4bca

p-j-smith requested review from drmatthews and paddyroddy October 20, 2023 11:03

paddyroddy approved these changes Oct 20, 2023

View reviewed changes

drmatthews approved these changes Oct 20, 2023

View reviewed changes

p-j-smith merged commit 4fe3371 into main Oct 20, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tidy up repo before first release #1

Tidy up repo before first release #1

p-j-smith commented Oct 20, 2023

drmatthews left a comment

drmatthews Oct 20, 2023

p-j-smith Oct 20, 2023

paddyroddy left a comment

drmatthews left a comment

Tidy up repo before first release #1

Tidy up repo before first release #1

Conversation

p-j-smith commented Oct 20, 2023

drmatthews left a comment

Choose a reason for hiding this comment

drmatthews Oct 20, 2023

Choose a reason for hiding this comment

p-j-smith Oct 20, 2023

Choose a reason for hiding this comment

paddyroddy left a comment

Choose a reason for hiding this comment

drmatthews left a comment

Choose a reason for hiding this comment