Fix linting #9
Merged
Fix linting #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise ansible-lint treats it like a playbook and errors
molecule setup is in the tests/ folder at the collection level
drmatthews
approved these changes
Nov 30, 2023
This was referenced Nov 30, 2023
Closed
p-j-smith
added a commit
to UCL-MIRSG/ansible-collection-xnat
that referenced
this pull request
Dec 7, 2023
- to make Ansible-lint happy, `EXTERNAL_STORAGE_DRIVE` has been renamed to `external_storage_drive`. This change was also made in the [infrastructure collection when fixing some linting issues](UCL-MIRSG/ansible-collection-infra#9). - define `external_storage_drive` as an inventory variable rather than a playbook one, otherwise we can't override it at the inventory level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8
verify-firewalld.ymltask file into a separate folder, otherwise ansible-lint treats it like a playbook and errorsEXTERNAL_STORAGE_DRIVEtoexternal_storage_drivevar-naming[no-role-prefix]to warn list - we could fix these issues instead, but perhaps in a separate pr as it will require quite a lot of changes?