Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base configs for molecule setup #38

Merged
merged 33 commits into from
Jan 11, 2024
Merged

Use base configs for molecule setup #38

merged 33 commits into from
Jan 11, 2024

Conversation

p-j-smith
Copy link
Contributor

@p-j-smith p-j-smith commented Jan 5, 2024 •
edited
Loading

  • update mirsg hooks
  • add base configs for centos 7 and rocky 9 to the tests/ folder
  • move role testing configuration to the role level (as is typical for molecule) (playbook configuration is still in test/ and can be moved in a separate PR)
  • update workflows to use base configs when running molecule
  • update READMEs with new description of test setup

@p-j-smith p-j-smith marked this pull request as draft January 5, 2024 16:24
@p-j-smith p-j-smith force-pushed the feat/molecule-base-config branch from 29be213 to 5e07014 Compare January 5, 2024 16:51
@p-j-smith
Add a centos 7 base config for molecule
41dec60
@p-j-smith
Add a rocky 9 base config for molecule
42327be
@p-j-smith
Add molecule setup for provision role that uses the base configs
6aa3a56
@p-j-smith
Update provision workflow to use base configs
cfc52f4
@p-j-smith
Use latest version of mirsg hooks
b4b8ae6
@p-j-smith
Use latest version of mirsg molecule-test
2d9b908
@p-j-smith
Fix base_config input to molecule-test
80a4d5b
@p-j-smith
Remove unused variables from provision test group vars
559c22f
@p-j-smith
Add molecule setup for firewalld role that uses base config
6978834
@p-j-smith
Update firewalld workflow to use base configs
975a6ca
@p-j-smith
remove unnecessary platforms from provision and firewalld molecule co…
5bf3056 
…nfigs
@p-j-smith
Add correct prepare, converge, and verify playbook for testing firewalld
919bed0
@p-j-smith
Add run-tags back to molecule-test workflow
b5f7baa
@p-j-smith
rename tests_path and base_config_path to tests-path and base-config-…
b9b282c 
…path
@p-j-smith
add molecule setup for postgresql role that uses the base configs
59eb5f0
@p-j-smith
Only set necessary vars for postgresql molecule testing
2b7ed68
@p-j-smith
Add molecule setup for provision_accounts that uses the base configs
0ba06b5
@p-j-smith
Update provision_accounts workflow to use molecule base configs
2eef41a
@p-j-smith
Add molecule setup that uses the base configs for install_python
31a9443
@p-j-smith
Update molecule-python workflow to use molecule base configs
952eb99
@p-j-smith
Set correct tests path for molecule-postgresql workflow
0da0109
@p-j-smith
Remove molecule set for roles from tests/ folder
da17b72 
roles now have their own molecule setup using the base config files
@p-j-smith
Fix firewalld molecule verify
329fc9b
@p-j-smith p-j-smith force-pushed the feat/molecule-base-config branch from 550d37a to 329fc9b Compare January 11, 2024 14:05
drmatthews
drmatthews reviewed Jan 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
drmatthews
drmatthews reviewed Jan 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
drmatthews
drmatthews reviewed Jan 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
drmatthews
drmatthews reviewed Jan 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
drmatthews
drmatthews reviewed Jan 11, 2024
View reviewed changes
roles/README.md Outdated Show resolved Hide resolved
drmatthews
drmatthews reviewed Jan 11, 2024
View reviewed changes
roles/README.md Outdated Show resolved Hide resolved
drmatthews
drmatthews reviewed Jan 11, 2024
View reviewed changes
roles/README.md Outdated Show resolved Hide resolved
drmatthews
drmatthews reviewed Jan 11, 2024
View reviewed changes
roles/README.md Outdated Show resolved Hide resolved
drmatthews
drmatthews reviewed Jan 11, 2024
View reviewed changes
roles/README.md Outdated Show resolved Hide resolved
drmatthews
drmatthews reviewed Jan 11, 2024
View reviewed changes
roles/README.md Outdated Show resolved Hide resolved
@p-j-smith @drmatthews
Fix typos
917b57e 
Co-authored-by: Daniel Matthews <[email protected]>
drmatthews
drmatthews requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@drmatthews drmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few typos.

@p-j-smith
Copy link
Contributor Author

Looks great! Just a few typos.

thanks for spotting all the typos! Should all be fixed now

@drmatthews drmatthews self-requested a review January 11, 2024 17:38
drmatthews
drmatthews approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@drmatthews drmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@p-j-smith p-j-smith merged commit 9b03f71 into main Jan 11, 2024
15 checks passed
@p-j-smith p-j-smith deleted the feat/molecule-base-config branch January 11, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmatthews drmatthews drmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-j-smith @drmatthews