Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme with installation and usage instructions #14

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Update readme with installation and usage instructions #14

merged 5 commits into from
Dec 13, 2023

Conversation

p-j-smith
Copy link
Contributor

  • update readme with installation and usage instructions
  • also add code style, license, and author info

@p-j-smith p-j-smith self-assigned this Dec 13, 2023
@p-j-smith p-j-smith requested a review from a team December 13, 2023 12:08
drmatthews
drmatthews requested changes Dec 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated
container (named `instance`):

```
docker exec -it instance /bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
docker exec -it instance /bin/bash
molecule login -s centos7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo I didn't know you could do that!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added your suggestion and changed the text directly above it to reflect the change

@drmatthews drmatthews self-requested a review December 13, 2023 12:56
drmatthews
drmatthews approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@drmatthews drmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@p-j-smith p-j-smith merged commit d256ef6 into main Dec 13, 2023
1 check passed
@p-j-smith p-j-smith deleted the docs/readme branch December 13, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmatthews drmatthews drmatthews approved these changes

Assignees

@p-j-smith p-j-smith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-j-smith @drmatthews