This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Switch from branch protection to rulesets
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HChughtai
approved these changes
Jun 10, 2024
|
I've checked in @astro-informatics and @UCL-ARC and they both have |
|
Not sure if this is actually working. Made a dummy repo and can see other settings are there, but no rulesets. |
|
It did pass validation though https://github.com/UCL-MIRSG/admin/runs/26030069361 |
|
Possibly related? github/safe-settings#553 Although not documented |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that GitHub has now defaulted to
rulesetsThe app https://github.com/github/safe-settings has been updated to include rulesets. This PR adds to rulesets:
Default: prevents force push & deletion onmainPull Requests: standard PR things (that @renovatebot can bypass when automerging)Usually I manually create these two, and create a separate status checks one. But we can't do that here, as that would require all repos to have the same named status checks that they won't in general have.