This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Turn off required status checks #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-j-smith
approved these changes
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I had tested this in the
.githubrepo, but I think something is configured so that repo behaves differently to others.Turns out, having the
context: []means that anything you enablesafe-settingswill re-enable. We could fill that withlintingbut not all repos have that workflow + I think this would then limit others to add. So better not have that setting at all. Discussed here github/safe-settings#412.Note, in general, we do want required status checks. For now, we will just have to apply them manually.