Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch packaging to pyproject.toml #429

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

ZedThree
Copy link
Contributor

@ZedThree ZedThree commented Aug 5, 2024

Also requires switching auto-versioning to setuptools_scm from versioneer, as the latter doesn't work with pyproject.toml-only packages

Closes #420

Also requires switching auto-versioning to `setuptools_scm` from
`versioneer`, as the latter doesn't work with `pyproject.toml`-only packages
@ZedThree
Copy link
Contributor Author

ZedThree commented Aug 5, 2024

Benchmark is failing because the PR is from a fork and so doesn't have push permissions

@ZedThree
Copy link
Contributor Author

ZedThree commented Aug 5, 2024

This will also fix the docs not building most of the API: https://easyvvuq.readthedocs.io/en/dev/py-modindex.html

@ZedThree
Copy link
Contributor Author

ZedThree commented Aug 5, 2024

This would be pretty trivial to get working with numpy 2.0 as well, the only changes required are:

  • replace four instances of np.in1d with np.isin
  • loosen the pinned chaospy and numpoly versions

Would you like those changes in this PR or a separate one?

Copy link
Collaborator

@DavidPCoster DavidPCoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert on TOML but this looks OK to me

@DavidPCoster DavidPCoster requested a review from djgroen December 4, 2024 09:52
@djgroen
Copy link
Contributor

djgroen commented Dec 4, 2024

There's an autopush task failing for some reason. I'll try to rerun the tests.

@djgroen
Copy link
Contributor

djgroen commented Dec 4, 2024

Ok, I'm inclined to approve and merge this in and then look into the benchmark build issue if it still exists. Because it's a token error, I suspect this could be a spurious problem?

Copy link
Contributor

@djgroen djgroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally okay to me. pyproject.toml may need updating, but since the build and tests pass there are no obvious dependency issues at the moment.

@djgroen djgroen merged commit 20bad93 into UCL-CCS:dev Dec 4, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move from setup.py to pyproject.toml
3 participants