-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch packaging to pyproject.toml
#429
Conversation
Also requires switching auto-versioning to `setuptools_scm` from `versioneer`, as the latter doesn't work with `pyproject.toml`-only packages
Benchmark is failing because the PR is from a fork and so doesn't have push permissions |
This will also fix the docs not building most of the API: https://easyvvuq.readthedocs.io/en/dev/py-modindex.html |
This would be pretty trivial to get working with numpy 2.0 as well, the only changes required are:
Would you like those changes in this PR or a separate one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on TOML but this looks OK to me
There's an autopush task failing for some reason. I'll try to rerun the tests. |
Ok, I'm inclined to approve and merge this in and then look into the benchmark build issue if it still exists. Because it's a token error, I suspect this could be a spurious problem? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally okay to me. pyproject.toml may need updating, but since the build and tests pass there are no obvious dependency issues at the moment.
Also requires switching auto-versioning to
setuptools_scm
fromversioneer
, as the latter doesn't work withpyproject.toml
-only packagesCloses #420