-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/decrease needed memory (Issue 404) #405
Conversation
…might not be needed
…han noCorrelationMatrices=False, noOutputDistributions=False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a sensible and straightforward change.
I think this can be merged in, given that readthedocs is also broken in the main branch at the moment. We should try to fix that in the coming week imho. |
Could someone with admin privileges on the repository look at why we are seeing
with the status never being reported? I don't have sufficient access rights to do this myself! PS: readthedocs is no longer complaining after I committed a configuration file for it |
@DavidPCoster I gave you admin rights, you're basically one of the core maintainers at this point |
As described in #404, the PCE analysis code would sometimes use large amounts of memory. This pull request makes it possible to disable the calculation of the Correlation Matrices and Output Distributions. For one example, this decreased the memory usage to 2% of that previously required, and decreased the elapsed time to 12.7% of that previously required.