Closes #974 DNA misalignment #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you base this branch from dev or main? I see all these strange commits which makes me think it was based from main:
|
dave-doty
requested changes
Jun 7, 2024
|
I'm not really sure why these commits showed up. I remember branching from dev and the most recent commit, I rebased to dev. |
rayzhuca
force-pushed
the
974-dna-sequence-rendering-larger-font-size-than-grid-boxes
branch
from
8fa4396 to
9334aba
Compare
|
I had to |
dave-doty
approved these changes
Jun 7, 2024
dave-doty
deleted the
974-dna-sequence-rendering-larger-font-size-than-grid-boxes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes letter spacing for all font types by switching back to textLength as opposed to letterSpacing.
Description
We can see that the screenshot in #974, the user is using "Lucida Console", which explains the misalignment because the letterSpacing value is hardcoded for "Consolas" font. The fix the bug, we just switched back to using textLength.
Screenshots: