Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes exported SVG text being unjustified on PowerPoint.
Description
SVGTextContentElement
(SVGTextElement
,SVGTextPath
, etc.) is converted into character separated SVGTextElementsgetStartPositionOfChar
to get the position of individual characters in anySVGTextContentElement
. However,getStartPositionOfChar
does not carry over some specific attributes, such asdominant-baseline
andtransform
dominant-baseline
is calculated viadominant_baseline_matrix
andget_text_height
matrix_to_map
,dom_matrix_to_map
,point_to_map
is made to call some web API functionsCannot read properties of null (reading 'toString')
console error that appears immediately when website loads. (This is actually unrelated to justifying DNA sequences though.)Related issues
text-shadow
does not work on PowerPoint. PowerPoint does support stroke and paint-order for texts but it looks significantly worse and grainy than without it. (Notice the "A" under the modification in the PowerPoint screenshot.)Screenshots
SVG on scadnano:
Exported SVG after "export svg text separately" option:
Exported SVG in PowerPoint: