Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #959: display DNA sequence on extension in order 5' to 3' #960

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

dave-doty
Copy link
Member

fixes #959: display DNA sequence on extension in order 5' to 3'.

This is done by always drawing the path for the extension 5' to 3'. Previously we drew it left-to-right, but in cases where the 3' end is to the left of the 5' end, this helped display the extension name/label right-side up, but caused the sequence to appear backward. Since the DNA sequence issue is more serious and could lead to mistakes in the design, for now we'll favor fixing that, and make separate issues to deal with

  1. Displaying extension name/label right-side up in all cases.
  2. Displaying DNA sequence right-side up. Currently, for cases where the 3' end is to the left of the 5' end, just like the default for reverse domains, the DNA sequence is displayed in the correct order but upside down. We'll need a separate issue to display it right-side-up when that option is selected in the View menu for reverse domains.

@dave-doty dave-doty merged commit 3e68f72 into dev Dec 22, 2023
4 checks passed
@dave-doty dave-doty deleted the 959-display-dna-sequence-on-extension-in-order-5-to-3 branch December 22, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant