Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #999 - Right Justified Right Fields in Dialogs with Inputs #1007

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

beanbeanjuice
Copy link
Contributor

Description

I added CSS to right justify the input in labels for the dialog box.

Related Issue

Fixes #999. Input is now right-justified.

Motivation and Context

Fixes #999.

How Has This Been Tested?

Originally, the fix affected ALL dialogs, but I changed it to only affect dialogs and labels with inputs. This was tested on Windows 11, Chrome.

I am currently unsure of other forms of dialog boxes, but the two that I tested were;
File -> Load Example
Edit -> Set Geometric Parameters

Screenshots (if appropriate):

image

Previously, fixing #999 would apply fixes for ALL dialogs, which was not
intended. It now only provides a fix for dialogs with labels that have
inputs.
@beanbeanjuice beanbeanjuice self-assigned this Oct 24, 2024
@beanbeanjuice beanbeanjuice added the enhancement New feature or request label Oct 24, 2024
@beanbeanjuice beanbeanjuice linked an issue Oct 24, 2024 that may be closed by this pull request
Copy link
Member

@dave-doty dave-doty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make special css class dialog-item-right-justified-input for DialogText, DialogFloat, and DialogInteger, add to the list of classes only for those, and CSS format only that new CSS class.

@beanbeanjuice
Copy link
Contributor Author

Please take a look at the new changes. I've added specific CSS styles to only affect certain items. Please let me know if you want me to go the other route of adding a specific class for this instead.

Before

image
image
image
image

After

image
image
image
image

Copy link
Member

@dave-doty dave-doty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is what you showed me in the meeting, so I didn't check it myself. But your screenshots look good.

@beanbeanjuice beanbeanjuice merged commit 7db2cf0 into dev Nov 7, 2024
4 checks passed
@dave-doty dave-doty deleted the 999-right-justify-fields-in-dialogs branch November 8, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

right-justify fields in dialogs
2 participants